Skip to content
This repository was archived by the owner on Oct 21, 2023. It is now read-only.
This repository was archived by the owner on Oct 21, 2023. It is now read-only.

Leaving before round end reward skips MMR update for the round #1228

Description

@jimbojammesi

Describe the bug
If a player lands hits or gets hit during a round of battle and then that player leaves the server before the round ends, player MMR is not updated for what happened during that round for the leaver and anyone that hit the leaver. This leads to some unsatisfying game play in which a player can potentially not gain MMR for hitting someone if the person they hit disconnects before the round ends.

To Reproduce
Steps to reproduce the behavior:

  1. Play during a round of battle, landing hits on players and/or getting hit by players.
  2. Leave the server before the round ends / rewards are given
  3. MMR does not get properly updated for that round. (for both the leaver and anyone that hit them or was hit by them)

Expected behavior
MMR should still be updated as expected for all players based on who they hit and were hit by regardless of who leaves the server before round end.

Context

  • Bannerlord version v1.1.5.21456
  • cRPG version v79

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions