Skip to content

[FIX] Handling of HTTP response code 413#4685

Merged
joragua merged 3 commits into
masterfrom
fix/handle_413_http_response_code
Oct 6, 2025
Merged

[FIX] Handling of HTTP response code 413#4685
joragua merged 3 commits into
masterfrom
fix/handle_413_http_response_code

Conversation

@joragua

@joragua joragua commented Sep 24, 2025 •
edited by jesmrec
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4094

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

#4685 (comment)

@joragua joragua self-assigned this Sep 24, 2025
@joragua joragua changed the title [BUGFIX] Handling of HTTP response code 413 [FIX] Handling of HTTP response code 413 Sep 24, 2025
@joragua joragua linked an issue Sep 24, 2025 that may be closed by this pull request
[BUG] Handling of HTTP response code 413 #4094
Closed
@joragua joragua force-pushed the fix/handle_413_http_response_code branch 2 times, most recently from 8fcf6c4 to 02a28c9 Compare September 24, 2025 14:43
@joragua joragua marked this pull request as ready for review September 24, 2025 15:18
@joragua joragua requested a review from jesmrec September 24, 2025 15:18
@jesmrec

jesmrec commented Oct 2, 2025

Copy link
Copy Markdown
Member

LGTM 👍 . Moving to QA

@jesmrec

jesmrec commented Oct 3, 2025

Copy link
Copy Markdown
Member

About QA, there are two different cases:

  • The mocked 413 shows the correct error message in both uploads view and notification. So, in case the server returns a 413, the app behaviour is correct ✅
  • Trying to reproduce with a real very big file, i got some problems due to hardware restrictions in test devices.

Since this specific case affects only oC10 (oCIS with no space restriction beyond the quotas or the disk available space) and the 413 handling is correct, we can assume that a server response with such code will be correctly managed.

Let's move this forward

@joragua joragua force-pushed the fix/handle_413_http_response_code branch from a93e67f to 662c8dd Compare October 6, 2025 08:07
@joragua joragua merged commit 18ac85c into master Oct 6, 2025
11 checks passed
@joragua joragua deleted the fix/handle_413_http_response_code branch October 6, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Handling of HTTP response code 413

3 participants

@joragua @jesmrec @ownclouders