Skip to content

[TECHNICAL] Kotlinize PreviewTextFragment#4376

Merged
joragua merged 20 commits into
masterfrom
technical/kotlinize_text_preview
Apr 25, 2024
Merged

[TECHNICAL] Kotlinize PreviewTextFragment#4376
joragua merged 20 commits into
masterfrom
technical/kotlinize_text_preview

Conversation

@joragua

@joragua joragua commented Apr 10, 2024 •
edited by jesmrec
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4356

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

QA checks #4376 (comment)

@joragua joragua linked an issue Apr 10, 2024 that may be closed by this pull request
[TECHNICAL] Kotlinize PreviewTextFragment #4356
Closed
13 tasks
@joragua joragua self-assigned this Apr 10, 2024
@joragua joragua force-pushed the technical/kotlinize_text_preview branch 2 times, most recently from 11eee5c to 31c1405 Compare April 10, 2024 09:44
@JuancaG05 JuancaG05 marked this pull request as draft April 10, 2024 10:15
@joragua joragua force-pushed the technical/kotlinize_text_preview branch 2 times, most recently from 31500ab to bf9ab4e Compare April 11, 2024 12:36
@joragua joragua marked this pull request as ready for review April 15, 2024 07:52
@joragua joragua force-pushed the technical/kotlinize_text_preview branch from e829448 to cf78f8d Compare April 15, 2024 07:58
@JuancaG05 JuancaG05 self-requested a review April 15, 2024 08:12
JuancaG05
JuancaG05 suggested changes Apr 17, 2024
View reviewed changes

@JuancaG05 JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @joragua! I left some comments here for you to review 👍

Comment thread changelog/unreleased/4376 Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt
@joragua joragua force-pushed the technical/kotlinize_text_preview branch 3 times, most recently from 7037b05 to e1d52c0 Compare April 18, 2024 11:37
@joragua joragua requested a review from JuancaG05 April 18, 2024 11:39
JuancaG05
JuancaG05 suggested changes Apr 22, 2024
View reviewed changes

@JuancaG05 JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two tiny comments and we're done 😃 @joragua

Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewTextFragment.kt
joragua added 14 commits April 22, 2024 10:15
@joragua
refactor: kotlinized properties, lifecycle functions and other functions
28edbd0
@joragua
refactor: changed some nullable checks and private functions' organiz…
d9bcb59 
…ation
@joragua
refactor: some changes in static functions
c5a8bb0
@joragua
refactor: kotlinized TextLoadAsyncTask functions
09b5f05
@joragua
refactor: deleted legacy PreviewTextFragment
2aafec0
@joragua
refactor: changed the type of attributes in LoadAsyncTask and a nulla…
9a72d3c 
…ble parameter in FileDisplayActivity
@joragua
chore: fixed contribution calens file
ff05ab7
@joragua
refactor: changed some names of properties
9bdebeb
@joragua
chore: added calens file
8958ffc
@joragua
refactor: removed empty super methods
ff8ea20
@joragua
refactor: removed unnecessary super calls in AsyncTask
af6bb8f
@joragua
refactor: removed variables in onPostExecute and changed names of par…
0f40b77 
…ameters in AsyncTask
@joragua
refactor: replaced null safety by requireActivity() and changed one p…
297e109 
…arameter in AsyncTask
@joragua
refactor: changed logic in switch structure and added the two missing…
a683561 
… cases
@joragua joragua force-pushed the technical/kotlinize_text_preview branch from 9171a1e to 57eb415 Compare April 22, 2024 08:52
@joragua joragua requested a review from JuancaG05 April 22, 2024 08:53
JuancaG05
JuancaG05 approved these changes Apr 22, 2024
View reviewed changes

@JuancaG05 JuancaG05 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!! Good job @joragua 🥳!! Let's move this to QA

@jesmrec

jesmrec commented Apr 25, 2024

Copy link
Copy Markdown
Member

Regression over text preview

  • Preview .txt file from file list (both orientations)
  • Preview .txt file from details view (both orientations)
  • Preview markdown file (both orientations)
  • Preview markdown file in text mode (both orientations)

Not much more to test here, text previews are OK and now in Kotlin. Move on!

@joragua joragua merged commit 1be13d1 into master Apr 25, 2024
@joragua joragua deleted the technical/kotlinize_text_preview branch April 25, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@JuancaG05 JuancaG05 JuancaG05 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TECHNICAL] Kotlinize PreviewTextFragment

3 participants

@joragua @jesmrec @JuancaG05