Editorial: Plumb reason through abort and cancel algorithm wrappers#1300
Merged
Conversation
These are clearly intended to pass the reason through. Fixes whatwg#1241, fixes whatwg#1273.
Contributor
Author
|
#1275 was previously sent for review in April but hasn't been merged. Merging that PR would be another option. |
Contributor
Author
|
@domenic how would you (or another editor; it seems nontrivial to discover who) like to proceed? |
Member
|
That PR got stalled as the original person did not respond to review comments, so we can use this one! |
domenic
reviewed
Dec 20, 2023
| 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps: | ||
| 1. Let |result| be the result of running |cancelAlgorithm|, if |cancelAlgorithm| was given, or | ||
| 1. Let |cancelAlgorithmWrapper| be an algorithm that runs these steps given |reason|: | ||
| 1. Let |result| be the result of running |cancelAlgorithm| given |reason|, if |cancelAlgorithm| was given, or |
Member
There was a problem hiding this comment.
Rewrap to 100 chars here and below
Contributor
Author
There was a problem hiding this comment.
CONTRIBUTING.md in this repository says the line limit in this specification is 120 chars, unlike other WHATWG repositories.
Should I comply with that right now, or do you still want this wrapped at 100?
Member
There was a problem hiding this comment.
It looks like CONTRIBUTING.md is outdated; 100 would be best, please!
domenic
approved these changes
Jan 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are clearly intended to pass the reason through.
Fixes #1241, fixes #1273.
Preview | Diff