Fix: str.split coerces dtype by preserving meta dtype (Fixes #11884)Fix: preserve dtype in str.split meta construction (Issue #11884)#12357
Open
mahek1210 wants to merge 1 commit into
Conversation
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 21 files ±0 21 suites ±0 5h 24m 10s ⏱️ + 14m 18s For more details on these failures, see this check. Results for commit 1082a98. ± Comparison against base commit af4e5c3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix dtype coercion in str.split
This PR fixes Issue #11884 where
.str.split()coerces dtype to object.Root Cause
Meta construction did not preserve original dtype.
Fix
Pass
dtype=self.frame._meta.dtypewhen constructing meta.Testing