Skip to content

[FIX] Members with expiration date and long permission name are not correctly displayed#4841

Merged
jesmrec merged 4 commits into
masterfrom
fix/expiration_date_in_space_members
May 5, 2026
Merged

[FIX] Members with expiration date and long permission name are not correctly displayed#4841
jesmrec merged 4 commits into
masterfrom
fix/expiration_date_in_space_members

Conversation

@joragua

@joragua joragua commented May 4, 2026

Copy link
Copy Markdown
Member

Related Issues

App: #4793 #4781

This PR fixes some glitches/bugs in the space members UI:

  1. Member role is now ellipsized when the text is too long
  2. New landscape layout to display all information related to the member
  3. Added end margin to the member info layout (members list, edit member, add member)
  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

QA checks:

#4841 (comment)

Reports:

@joragua joragua self-assigned this May 4, 2026
@joragua joragua marked this pull request as ready for review May 4, 2026 10:31
@joragua joragua requested a review from jesmrec May 4, 2026 10:31

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving to QA 🚀

@jesmrec

jesmrec commented May 4, 2026

Copy link
Copy Markdown
Member

@jesmrec

jesmrec commented May 4, 2026

Copy link
Copy Markdown
Member

(1) [FIXED]

In a phone device:

  1. Add a member with Can edit with versions and trashbin and no expiration date

Current:

Screenshot 2026-05-04 at 13 36 35

Expected:

If no expiration date is set, the permission shouldn't be elipsized

Xiaomi Redmi Note 13, Android 15
61d89c19

@joragua joragua force-pushed the fix/expiration_date_in_space_members branch from 56c834d to 9465cf1 Compare May 4, 2026 12:31
@joragua

joragua commented May 4, 2026

Copy link
Copy Markdown
Member Author

(1) should be fixed in commit 9465cf1

The member role is now ellipsized when the expiration date is shown in the layout

@jesmrec

jesmrec commented May 4, 2026

Copy link
Copy Markdown
Member

(2) [FIXED]

It may be caused by (1)

  1. Add a member with Can edit with versions and trashbin permission and expiration date
  2. Rotate the device to landscape orientation

Current:

Screenshot 2026-05-04 at 14 47 50

Expected:

in landscape, there is enough space to show the permissions' long name.

Xiaomi Redmi Note 13, Android 15
9465cf113

@joragua joragua force-pushed the fix/expiration_date_in_space_members branch from 9465cf1 to adf78d5 Compare May 5, 2026 08:12
@joragua joragua force-pushed the fix/expiration_date_in_space_members branch from adf78d5 to cb71062 Compare May 5, 2026 09:52
@joragua

joragua commented May 5, 2026

Copy link
Copy Markdown
Member Author

(2) was reproduced due to commit 9465cf1 (regression)

I've rebased that commit and now, (1) and (2) should be fixed in commit cb71062

@jesmrec

jesmrec commented May 5, 2026

Copy link
Copy Markdown
Member

(1) and (2) fixed.

Both attached items fixed.

Approved on my side

@jesmrec jesmrec merged commit 9c06201 into master May 5, 2026
11 checks passed
@jesmrec jesmrec deleted the fix/expiration_date_in_space_members branch May 5, 2026 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants