awx/main/tests/functional/migrations/test_0206_remove_old_rbac_indexes.py (2)

7-8: Consider removing @pytest.mark.django_db if no DB access is needed.

The tests only inspect the migration module's structure and don't interact with the database. The decorator adds overhead by setting up database transactions for each test.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@awx/main/tests/functional/migrations/test_0206_remove_old_rbac_indexes.py`
around lines 7 - 8, The class-level `@pytest.mark.django_db` on
TestRemoveOldRbacIndexes is unnecessary if none of its tests access the
database; remove the decorator from the TestRemoveOldRbacIndexes class (or move
the marker to only those individual test methods that require DB access) so
tests that merely inspect the migration module's structure don't incur DB setup
overhead.

---

66-71: Dead code: parts and table variables are unused.

Lines 67-68 compute parts and table but the actual table extraction logic on lines 69-71 ignores them entirely, relying instead on idx.startswith(expected).

♻️ Proposed simplification

     def test_covers_all_model_tables(self):
         expected_tables = {
             'main_credential',
             'main_instancegroup',
             'main_inventory',
             'main_jobtemplate',
             'main_organization',
             'main_project',
             'main_team',
             'main_workflowjobtemplate',
             'main_activitystream_role',
         }
         actual_tables = set()
         for idx in self.migration_module.OLD_RBAC_FK_INDEXES:
-            parts = idx.rsplit('_role_id', 1)
-            table = parts[0].rsplit('_', 0)[0]
             for expected in expected_tables:
                 if idx.startswith(expected):
                     actual_tables.add(expected)
         assert actual_tables == expected_tables

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@awx/main/tests/functional/migrations/test_0206_remove_old_rbac_indexes.py`
around lines 66 - 71, The variables parts and table computed from each idx in
migration_module.OLD_RBAC_FK_INDEXES are unused; remove the dead computations
(the lines that set parts = idx.rsplit('_role_id', 1) and table =
parts[0].rsplit('_', 0)[0]) and keep the existing startswith-based check against
expected_tables that populates actual_tables, ensuring no other code depends on
parts/table.

awx/main/tests/functional/migrations/test_0206_remove_implicit_role_field_indexes.py (1)

21-27: ⚡ Quick win

Assert operation count directly to avoid vacuous passes.

Current checks can still pass if Migration.operations is empty. Add a direct count assertion tied to IMPLICIT_ROLE_FIELDS.

Proposed test hardening

     def test_migration_targets_correct_field_count(self):
         assert len(self.migration_module.IMPLICIT_ROLE_FIELDS) == 38
+        assert len(self.migration_module.Migration.operations) == len(self.migration_module.IMPLICIT_ROLE_FIELDS)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@awx/main/tests/functional/migrations/test_0206_remove_implicit_role_field_indexes.py`
around lines 21 - 27, The test can vacuously pass if Migration.operations is
empty; add an explicit assertion that the number of migration operations equals
the number of implicit fields to harden the test. In
test_all_altered_fields_disable_db_index, assert len(Migration.operations) ==
len(self.migration_module.IMPLICIT_ROLE_FIELDS) (or == 38 to match
test_migration_targets_correct_field_count) before iterating, so you ensure
Migration.operations is populated and aligned with IMPLICIT_ROLE_FIELDS.